-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gradle 8 publishing issue #1904
Conversation
Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anyone have a preference for how to list dependencies?
I noticed in the GATK that it seems to be more like "Option a)" below.
distZip { | ||
dependsOn 'currentJar' | ||
} | ||
|
||
distTar { | ||
dependsOn 'currentJar' | ||
} | ||
|
||
startScripts { | ||
dependsOn 'currentJar' | ||
} | ||
|
||
startShadowScripts { | ||
dependsOn 'currentJar' | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Option a) Multiple independent dependencies
// For Gradle 8 explicitly add 'currentJar' as a dependency of the following tasks. | ||
// For more information, please refer to | ||
// https://docs.gradle.org/8.2.1/userguide/validation_problems.html#implicit_dependency in the Gradle documentation. | ||
['distZip', 'distTar', 'startScripts', 'startShadowScripts', 'generateMetadataFileForPicardPublication'].each { | ||
tasks.named(it).configure { | ||
dependsOn 'currentJar' | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Option b) Use a loop to put them all in one place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like there is probably a more idiomatic way to do this by adding it to the java component or something like that, but I don't know how and it doesn't seem worthwhile to figure it. This is way better than a zillion individual closures adding it.
Description
Fixes
gradle publish
after changes in #1903Checklist (never delete this)
Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.
Content
Review
For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests